fix(gitea): retire deprecated [server] LFS_CONTENT_PATH; disable query auth tokens #383

2026-07-24T08:38:12Z

claude-bot commented

2026-07-24 08:38:12 +00:00

Clears the two startup notices on the Gitea admin dashboard.

[server] LFS_CONTENT_PATH is deprecated in favour of [lfs] PATH (Gitea 1.21.4 logs a removal warning).
DISABLE_QUERY_AUTH_TOKEN is recommended and becomes the default in 1.23.

Both added as GITEA__ env overrides so they're tracked in git. environment-to-ini can only add keys, so the stale [server] LFS_CONTENT_PATH was also removed from the on-PVC app.ini by hand (same path value, existing data/lfs objects untouched). The live pod was fixed + restarted out-of-band; this PR makes the config durable across pod recreations.

Clears the two startup notices on the Gitea admin dashboard. - `[server] LFS_CONTENT_PATH` is deprecated in favour of `[lfs] PATH` (Gitea 1.21.4 logs a removal warning). - `DISABLE_QUERY_AUTH_TOKEN` is recommended and becomes the default in 1.23. Both added as `GITEA__` env overrides so they're tracked in git. `environment-to-ini` can only add keys, so the stale `[server] LFS_CONTENT_PATH` was also removed from the on-PVC `app.ini` by hand (same path value, existing `data/lfs` objects untouched). The live pod was fixed + restarted out-of-band; this PR makes the config durable across pod recreations.

claude-bot added 1 commit 2026-07-24 08:38:12 +00:00

fix(gitea): retire deprecated [server] LFS_CONTENT_PATH; disable query auth tokens

ci/woodpecker/pr/pr-review Pipeline was successful

Details

d09688bac9

Gitea 1.21.4 logs a deprecation warning for [server] LFS_CONTENT_PATH
(superseded by [lfs] PATH) and recommends DISABLE_QUERY_AUTH_TOKEN
(default from 1.23). Both surface as startup notices on the admin
dashboard.

Add the replacements as GITEA__ env overrides so they are tracked in
git. environment-to-ini can only add keys, so the stale
[server] LFS_CONTENT_PATH was also removed from the on-PVC app.ini by
hand (same path value -> existing data/lfs objects untouched).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

review-bot reviewed

2026-07-24 08:40:10 +00:00

review-bot left a comment

🤖 Automated review — model claude-haiku-4-5-20251001 (complexity: trivial), commit d09688bac9c51babcfece24ef6e8033698f58639.

Advisory review by the review-bot pipeline. It never approves; a human merges. Push new commits to get a fresh review.

Summary

This PR addresses two Gitea deprecation warnings on the admin dashboard by adding environment-variable overrides to the StatefulSet. The changes migrate from deprecated [server] LFS_CONTENT_PATH to the new [lfs] PATH configuration, and enable DISABLE_QUERY_AUTH_TOKEN (recommended practice and the default in Gitea 1.23). Both changes are low-risk: the functionality remains identical, the environment variable syntax matches existing patterns in the file, and the security implications have been verified.

🔴 Blocking

None.

🟡 Suggestions

No blocking issues identified. The PR is well-documented and correctly implemented. One optional note:

YAML consistency (minor): The GITEA__lfs__PATH value /var/lib/gitea/data/lfs is unquoted, while other string values like "true" and "4h" use quotes. This follows the file's pattern of leaving paths unquoted (consistent with line 43: value: /var/lib/gitea), so it's acceptable, but using consistent quoting style across all string values would improve readability.

🟢 Nits

None.

Tests

This is a Kubernetes manifest change (configuration, not code), so unit tests don't apply. The PR body indicates the live pod was already fixed and restarted out-of-band to verify the changes work. The deprecation warnings should clear once the pod restarts with these environment variables and the manually-edited PVC app.ini is in place.

Recommendation

Looks reasonable — no blocking issues; comments above are optional.

🤖 **Automated review** — model `claude-haiku-4-5-20251001` (complexity: trivial), commit `d09688bac9c51babcfece24ef6e8033698f58639`. > Advisory review by the `review-bot` pipeline. It never approves; a human merges. Push new commits to get a fresh review. --- ## Summary This PR addresses two Gitea deprecation warnings on the admin dashboard by adding environment-variable overrides to the StatefulSet. The changes migrate from deprecated `[server] LFS_CONTENT_PATH` to the new `[lfs] PATH` configuration, and enable `DISABLE_QUERY_AUTH_TOKEN` (recommended practice and the default in Gitea 1.23). Both changes are low-risk: the functionality remains identical, the environment variable syntax matches existing patterns in the file, and the security implications have been verified. ## 🔴 Blocking None. ## 🟡 Suggestions No blocking issues identified. The PR is well-documented and correctly implemented. One optional note: - **YAML consistency (minor)**: The `GITEA__lfs__PATH` value `/var/lib/gitea/data/lfs` is unquoted, while other string values like `"true"` and `"4h"` use quotes. This follows the file's pattern of leaving paths unquoted (consistent with line 43: `value: /var/lib/gitea`), so it's acceptable, but using consistent quoting style across all string values would improve readability. ## 🟢 Nits None. ## Tests This is a Kubernetes manifest change (configuration, not code), so unit tests don't apply. The PR body indicates the live pod was already fixed and restarted out-of-band to verify the changes work. The deprecation warnings should clear once the pod restarts with these environment variables and the manually-edited PVC app.ini is in place. ## Recommendation Looks reasonable — no blocking issues; comments above are optional.

k.renner merged commit f933ae5a6e into master

2026-07-24 08:41:17 +00:00

k.renner referenced this issue from a commit

2026-07-24 08:41:17 +00:00

Merge pull request 'fix(gitea): retire deprecated [server] LFS_CONTENT_PATH; disable query auth tokens' (#383) from gitea-lfs-deprecation into master

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: konairius/homelab#383