chore(ci): drop the Talos image seeding step #612

2026-08-26T00:36:04Z

claude-bot commented

2026-08-26 00:36:04 +00:00

The step pushed a nocloud Talos image onto each Proxmox node so the k8s VMs could boot from it. No Proxmox node remains — neptune was the last one, and all three control-plane nodes now boot the metal image from their own installed disk.

Left in place it calls the Proxmox storage API for a host that no longer answers, then sits through its full 60x10s download-wait before giving up, on every infrastructure apply.

The block scheduled its own removal:

Only nodes still running Proxmox belong in this list. [...] the whole step goes away once neptune is converted too.

Pure deletion — 36 lines, nothing else in the pipeline referenced TALOS_VERSION, TALOS_SCHEMATIC, TALOS_URL or TALOS_FILENAME.

This is the narrow, safe part of the Proxmox teardown. The broader surface — opentofu/vm_152_k8s_3.tf, the proxmox_vm/proxmox_lxc modules, the provider config, sync_state_from_pve.py, ansible/inventory/api.proxmox.yaml — is a much larger change and is deliberately left for a separate, deliberate pass rather than folded in here.

The step pushed a nocloud Talos image onto each Proxmox node so the k8s VMs could boot from it. **No Proxmox node remains** — neptune was the last one, and all three control-plane nodes now boot the metal image from their own installed disk. Left in place it calls the Proxmox storage API for a host that no longer answers, then sits through its full `60x10s` download-wait before giving up, on every infrastructure apply. The block scheduled its own removal: > Only nodes still running Proxmox belong in this list. [...] **the whole step goes away once neptune is converted too.** Pure deletion — 36 lines, nothing else in the pipeline referenced `TALOS_VERSION`, `TALOS_SCHEMATIC`, `TALOS_URL` or `TALOS_FILENAME`. This is the narrow, safe part of the Proxmox teardown. The broader surface — `opentofu/vm_152_k8s_3.tf`, the `proxmox_vm`/`proxmox_lxc` modules, the provider config, `sync_state_from_pve.py`, `ansible/inventory/api.proxmox.yaml` — is a much larger change and is deliberately left for a separate, deliberate pass rather than folded in here.

claude-bot added 1 commit 2026-08-26 00:36:04 +00:00

chore(ci): drop the Talos image seeding step

ci/woodpecker/pr/ci-manifests-test Pipeline was successful

Details

ci/woodpecker/pr/ci-scripts-test Pipeline was successful

Details

ci/woodpecker/pr/pr-review Pipeline was successful

Details

43143847e9

The step pushed a nocloud Talos image onto each Proxmox node so the k8s VMs
could boot from it. No Proxmox node remains — neptune was the last one, and all
three control-plane nodes now boot the metal image from their own installed
disk.

Left in place the step would call the Proxmox storage API for a host that no
longer answers it, then sit through its 60x10s download-wait before giving up,
on every infrastructure apply.

The block's own comment already scheduled its removal: "the whole step goes away
once neptune is converted too."

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

review-bot reviewed

2026-08-26 00:38:29 +00:00

review-bot left a comment

🤖 Automated review — model claude-haiku-4-5-20251001 (complexity: trivial), commit 43143847e99a71917b9bc5cdea73527f877ec4df.

Advisory review by the review-bot pipeline. It never approves; a human merges. Push new commits to get a fresh review.

Summary

This PR removes 36 lines of a stale Talos image seeding step from the CI pipeline. The step was designed to download a Talos image to Proxmox storage, but all Proxmox nodes have been converted to bare metal and no longer need this initialization. The deletion is safe and correctly scoped — only this pipeline step is affected, with broader Proxmox infrastructure teardown intentionally deferred.

🟡 Suggestions

Outdated comment in opentofu/talos_image.tf:line 4

The comment references TALOS_SCHEMATIC in the now-deleted .woodpecker/deploy-infrastructure.yml:

Keep in sync with TALOS_SCHEMATIC in .woodpecker/deploy-infrastructure.yml

This is no longer accurate. While the PR author correctly notes that talos_image.tf is part of the broader Proxmox teardown (to be handled separately), the stale comment could confuse future readers. Consider updating it to document that the pipeline no longer seeds the image, or removing the sync requirement if talos_image.tf is being retained for other reasons.

Tests

No tests apply — this is a pure CI configuration deletion.

Recommendation

Looks reasonable — no blocking issues; the comment above is optional but recommended.

🤖 **Automated review** — model `claude-haiku-4-5-20251001` (complexity: trivial), commit `43143847e99a71917b9bc5cdea73527f877ec4df`. > Advisory review by the `review-bot` pipeline. It never approves; a human merges. Push new commits to get a fresh review. --- ## Summary This PR removes 36 lines of a stale Talos image seeding step from the CI pipeline. The step was designed to download a Talos image to Proxmox storage, but all Proxmox nodes have been converted to bare metal and no longer need this initialization. The deletion is safe and correctly scoped — only this pipeline step is affected, with broader Proxmox infrastructure teardown intentionally deferred. ## 🟡 Suggestions **Outdated comment in opentofu/talos_image.tf:line 4** The comment references `TALOS_SCHEMATIC` in the now-deleted `.woodpecker/deploy-infrastructure.yml`: ``` Keep in sync with TALOS_SCHEMATIC in .woodpecker/deploy-infrastructure.yml ``` This is no longer accurate. While the PR author correctly notes that `talos_image.tf` is part of the broader Proxmox teardown (to be handled separately), the stale comment could confuse future readers. Consider updating it to document that the pipeline no longer seeds the image, or removing the sync requirement if `talos_image.tf` is being retained for other reasons. ## Tests No tests apply — this is a pure CI configuration deletion. ## Recommendation Looks reasonable — no blocking issues; the comment above is optional but recommended.

k.renner merged commit 357f8d79c2 into master

2026-08-26 04:38:39 +00:00

k.renner referenced this issue from a commit

2026-08-26 04:38:39 +00:00

Merge pull request 'chore(ci): drop the Talos image seeding step' (#612) from drop-talos-image-seeding into master

claude-bot referenced this pull request

2026-08-26 05:05:48 +00:00

fix(opentofu): drop the last Proxmox VM and forget it from state #621

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: konairius/homelab#612