test(kuma-sync): live smoke-test KumaMonitor #1351

Merged
k.renner merged 1 commits from feat/kuma-sync-smoke into master 2026-10-19 06:00:18 +00:00
Member

Plan kuma-sync Task 7 step 4. One KumaMonitor in namespace kuma-sync: keyword "Familie Renner" on https://www.renner.uno/ with certificate-expiry notification. Validated with a server-side dry run against the live CRD.

After merge, checks:

  1. The monitor shows up in Kuma, tagged kuma-sync=kuma-sync/www-renner-uno, and goes UP; the KumaMonitor reports Ready/Synced.
  2. Deleting the pod changes nothing in Kuma (same monitor ID, no duplicate).
  3. A follow-up PR removes this file; the monitor is then deleted from Kuma.

🤖 Generated with Claude Code

Plan kuma-sync Task 7 step 4. One KumaMonitor in namespace `kuma-sync`: keyword "Familie Renner" on https://www.renner.uno/ with certificate-expiry notification. Validated with a server-side dry run against the live CRD. After merge, checks: 1. The monitor shows up in Kuma, tagged `kuma-sync=kuma-sync/www-renner-uno`, and goes UP; the KumaMonitor reports Ready/Synced. 2. Deleting the pod changes nothing in Kuma (same monitor ID, no duplicate). 3. A follow-up PR removes this file; the monitor is then deleted from Kuma. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-bot added 1 commit 2026-10-19 05:58:07 +00:00
test(kuma-sync): live smoke-test KumaMonitor for www.renner.uno
ci/woodpecker/pr/ci-scripts-test Pipeline was successful
review-bot reviewed: comment
ci/woodpecker/pr/ci-manifests-test Pipeline was successful
fafc73cb3f
Keyword check on https://www.renner.uno/ (page title "Familie Renner")
with certificate-expiry notification. Exercises create, tagging,
restart adoption and deletion against the live Kuma; removed from git
again as the last smoke-test step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review-bot left a comment
Member

🤖 Automated review — model claude-sonnet-5-5, commit fafc73cb3fb244d69e96135194359407758774d7.

Automated review by the review-bot: it approves only when it found nothing red or yellow, and a human still merges. Push new commits to get a fresh review.


Summary

This adds one KumaMonitor (kuma-sync/www-renner-uno) to the kuma-sync kustomization. It is a keyword check for "Familie Renner" on https://www.renner.uno/ with certificate-expiry notification, as plan Task 7 step 4 describes. The manifest is valid against the CRD, matches the plan and PR text, and doesn't conflict with master.

⚪ Unverified

  • Keyword on the live page: I could not read the rendered www.renner.uno page, so I can't confirm "Familie Renner" appears in it. The WordPress ingress at kubernetes/apps/wordpress/ingress.yaml does serve / publicly without the Authentik gate. If the string is absent, the monitor reports DOWN even though the site is fine, and it is easy to correct. This is part of what the PR's post-merge check 1 verifies.
  • Flux wait: true and the new monitor: kubernetes/clusters/homelab/kuma-sync.yaml has wait: true, timeout: 5m and prune: true, and the KumaMonitor is now in that same kustomization. Whether Flux's status checker treats a KumaMonitor with Ready=False (for example KumaUnavailable) as "not ready" is behaviour I did not confirm. If it does, a Kuma outage would mark the whole kustomization, including the controller Deployment, as failing after 5 minutes. It would retry every 2 minutes and recover, so this is low impact.

🟡 Suggestions

  • kubernetes/apps/kuma-sync/smoke-kumamonitor.yaml:1: the file is meant to be temporary (the PR body says a follow-up PR removes it). A one-line comment at the top saying it is a smoke test to delete after verification would stop it being mistaken for a permanent monitor. The comment style in the sibling manifests suggests the repo prefers such notes.

Tests

No automated tests are needed for a single declarative manifest. The CRD validation (crd-kumamonitors.yaml, type: keyword requires both http and keyword) is covered by ci/images/kuma-sync/api/v1alpha1/validation_test.go. The restart and delete behaviour is covered by the controller tests and by the live checks listed in the PR body.

Recommendation

Looks reasonable — no blocking issues; comments above are optional.

🤖 **Automated review** — model `claude-sonnet-5-5`, commit `fafc73cb3fb244d69e96135194359407758774d7`. > Automated review by the `review-bot`: it approves only when it found nothing red or yellow, and a human still merges. Push new commits to get a fresh review. --- ## Summary This adds one `KumaMonitor` (`kuma-sync/www-renner-uno`) to the kuma-sync kustomization. It is a keyword check for "Familie Renner" on `https://www.renner.uno/` with certificate-expiry notification, as plan Task 7 step 4 describes. The manifest is valid against the CRD, matches the plan and PR text, and doesn't conflict with `master`. ## ⚪ Unverified - **Keyword on the live page:** I could not read the rendered `www.renner.uno` page, so I can't confirm "Familie Renner" appears in it. The WordPress ingress at `kubernetes/apps/wordpress/ingress.yaml` does serve `/` publicly without the Authentik gate. If the string is absent, the monitor reports DOWN even though the site is fine, and it is easy to correct. This is part of what the PR's post-merge check 1 verifies. - **Flux `wait: true` and the new monitor:** `kubernetes/clusters/homelab/kuma-sync.yaml` has `wait: true`, `timeout: 5m` and `prune: true`, and the `KumaMonitor` is now in that same kustomization. Whether Flux's status checker treats a `KumaMonitor` with `Ready=False` (for example `KumaUnavailable`) as "not ready" is behaviour I did not confirm. If it does, a Kuma outage would mark the whole kustomization, including the controller Deployment, as failing after 5 minutes. It would retry every 2 minutes and recover, so this is low impact. ## 🟡 Suggestions - `kubernetes/apps/kuma-sync/smoke-kumamonitor.yaml:1`: the file is meant to be temporary (the PR body says a follow-up PR removes it). A one-line comment at the top saying it is a smoke test to delete after verification would stop it being mistaken for a permanent monitor. The comment style in the sibling manifests suggests the repo prefers such notes. ## Tests No automated tests are needed for a single declarative manifest. The CRD validation (`crd-kumamonitors.yaml`, `type: keyword` requires both `http` and `keyword`) is covered by `ci/images/kuma-sync/api/v1alpha1/validation_test.go`. The restart and delete behaviour is covered by the controller tests and by the live checks listed in the PR body. ## Recommendation Looks reasonable — no blocking issues; comments above are optional. <!-- pr-review:sha=fafc73cb3fb244d69e96135194359407758774d7 -->
k.renner merged commit 38c186d424 into master 2026-10-19 06:00:18 +00:00
Sign in to join this conversation.